Bugfix - E2E Share File From Other Apps

[alperozturk96]

• Tests written, or not not needed

Fixes:

• Resolved the crash issue.
• Made mParents variable compatible with encrypted files. The remotePath now uses the encrypted path instead of the decrypted path, allowing files to be uploaded via FileUploadWorker.

Steps to Reproduce:

1. Open the app and log in.
2. Use any gallery app to select a file, then share it to the NextCloud app.
3. On the “Choose upload folder” screen, select an encrypted folder.
4. Tap “Create new folder” and create a subfolder in the encrypted folder.
5. App will crash

Crash Report

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean [com.owncloud.android](http://com.owncloud.android/).datamodel.OCFile.canWrite()' on a null object reference
                                                    at [com.owncloud.android](http://com.owncloud.android/).ui.activity.ReceiveExternalFilesActivity.onCreateOptionsMenu([ReceiveExternalFilesActivity.java:1037](http://receiveexternalfilesactivity.java:1037/))
                                                    at [android.app](http://android.app/).Activity.onCreatePanelMenu([Activity.java:3680](http://activity.java:3680/))
                                                    at androidx.activity.ComponentActivity.onCreatePanelMenu(ComponentActivity.kt:470)
                                                    at androidx.appcompat.view.WindowCallbackWrapper.onCreatePanelMenu([WindowCallbackWrapper.java:94](http://windowcallbackwrapper.java:94/))
                                                    at [androidx.appcompat.app](http://androidx.appcompat.app/).AppCompatDelegateImpl$AppCompatWindowCallback.onCreatePanelMenu([AppCompatDelegateImpl.java:3413](http://appcompatdelegateimpl.java:3413/))
                                                    at [androidx.appcompat.app](http://androidx.appcompat.app/).ToolbarActionBar.populateOptionsMenu([ToolbarActionBar.java:458](http://toolbaractionbar.java:458/))
                                                    at [androidx.appcompat.app](http://androidx.appcompat.app/).ToolbarActionBar$1.run([ToolbarActionBar.java:58](http://toolbaractionbar.java:58/))
                                                    at android.view.Choreographer$CallbackRecord.run([Choreographer.java:1092](http://choreographer.java:1092/))
                                                    at android.view.Choreographer.doCallbacks([Choreographer.java:893](http://choreographer.java:893/))
                                                    at android.view.Choreographer.doFrame([Choreographer.java:809](http://choreographer.java:809/))
                                                    at android.view.Choreographer$FrameDisplayEventReceiver.run([Choreographer.java:1078](http://choreographer.java:1078/))
                                                    at android.os.Handler.handleCallback([Handler.java:907](http://handler.java:907/))
                                                    at android.os.Handler.dispatchMessage([Handler.java:105](http://handler.java:105/))
                                                    at android.os.Looper.loop([Looper.java:216](http://looper.java:216/))
                                                    at [android.app](http://android.app/).ActivityThread.main([ActivityThread.java:7625](http://activitythread.java:7625/))
                                                    at java.lang.reflect.Method.invoke(Native Method)
                                                    at [com.android](http://com.android/).internal.os.RuntimeInit$MethodAndArgsCaller.run([RuntimeInit.java:524](http://runtimeinit.java:524/))
                                                    at [com.android](http://com.android/).internal.os.ZygoteInit.main([ZygoteInit.java:987](http://zygoteinit.java:987/))

[alperozturk96]

/backport to stable-3.30

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	56	56
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	296	296
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	53	53
Security	18	18
Total	506	506

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14332.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[tobiasKaminsky]

\backport to stable-3.30

[tobiasKaminsky]

/backport to stable-3.30