Fix lock state icon position in detailed files' lists #176
Conversation
Jerome-Herbinet
requested review from
juliusknorr,
jancborchardt and
nimishavijay
There was a problem hiding this comment.
Looks good, butnis it not better to horizontally center it? And also, will this work with the Vue rewrite @skjnldsv?
|
@jancborchardt No, see discussion in #154 |
|
@juliushaertl the should this fix be merged so it's fixed for pre-Files2Vue versions? |
|
Need to double check all compatible versions first, but yes we should merge before f2v for the stable releases |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
css/files_lock.css
Outdated
| @@ -4,7 +4,7 @@ tr[data-locked='true'] .fileactions .action.action-menu.permanent { | |||
| } | |||
| .locking-inline-state.icon-password { | |||
| padding: 17px 23px; | |||
| margin-right: -45px; | |||
| margin-right: -49px; | |||
There was a problem hiding this comment.
Unfortunately this has a similar issue with entries that are not shared:
The following style changes seem to work though:
There was a problem hiding this comment.
Check last commit. Both UI content (shared and not shared) should display lock properly, including in grid view.
Signed-off-by: Jérôme Herbinet <[email protected]>
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-fix-lock-state-position
branch
from
c8ce5ec to
5814ba1
Compare
Signed-off-by: Jérôme Herbinet <[email protected]>
Before :
After :