-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add brute force protection to form endpoints #2269
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
============================================
- Coverage 43.40% 43.40% -0.01%
- Complexity 881 882 +1
============================================
Files 75 77 +2
Lines 3361 3359 -2
============================================
- Hits 1459 1458 -1
+ Misses 1902 1901 -1 |
Could you perhaps base this on my api PR? |
@susnux thanks to @provokateurin we could finally merge the OpenAPI PR, so I think that you can now go on with this PR and base it on the current main |
5b50cec
to
ca7f715
Compare
@Chartman123 rebased and adjusted to the new controller |
Endpoints that query for forms are now protected against brute force attacks to find valid forms, invalid hashes or IDs. Signed-off-by: Ferdinand Thiessen <[email protected]>
ca7f715
to
13870cd
Compare
Should we add the brute force protection to the page controller for public share hashes too? |
Signed-off-by: Christian Hartmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but I have little knowledge about the Forms app, so I have to leave it to someone else.
Co-authored-by: Christian Hartmann <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine now :) Just squash the commits and then we're good to go. And we can add the protection in the PageController in a follow-up :)
Endpoints that query for forms are now protected against brute force attacks to find valid forms, invalid hashes or IDs.