Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence eslint warning #2505

Merged
merged 1 commit into from
Jan 20, 2025
Merged

chore: silence eslint warning #2505

merged 1 commit into from
Jan 20, 2025

Conversation

Chartman123
Copy link
Collaborator

This removes an eslint warning for the available named export of isCancel in @nextcloud/axios as we also need other methods from this package.

Signed-off-by: Christian Hartmann <[email protected]

@Chartman123 Chartman123 added 3. to review Waiting for reviews technical debt Technical issue labels Jan 20, 2025
@Chartman123 Chartman123 requested a review from susnux January 20, 2025 11:05
@Chartman123 Chartman123 added this to the 5.0 milestone Jan 20, 2025
@Chartman123 Chartman123 self-assigned this Jan 20, 2025
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not import the named one?

@Chartman123
Copy link
Collaborator Author

We also need axios.get... Can we import the named one and still use that?

@susnux
Copy link
Collaborator

susnux commented Jan 20, 2025

We also need axios.get... Can we import the named one and still use that?

Sure:

import axios, { isCancel } from '@nextcloud/axios'

Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 requested a review from susnux January 20, 2025 12:03
@susnux susnux merged commit 9d65d90 into main Jan 20, 2025
47 checks passed
@susnux susnux deleted the chore/eslint-warning branch January 20, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants