Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix spreadsheet unlinking #2534

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: Fix spreadsheet unlinking #2534

merged 1 commit into from
Jan 29, 2025

Conversation

Koc
Copy link
Collaborator

@Koc Koc commented Jan 29, 2025

Closes #2528.

I can't compile and test it due to an error:

devcontainer@e0e910ca5f18:/var/www/html/apps/forms$ npm run dev

> [email protected] dev
> vite --mode development build

Building forms for development
error during build:
TypeError: crypto$2.getRandomValues is not a function
    at resolveConfig (file:///var/www/html/apps/forms/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:66562:16)
    at async build (file:///var/www/html/apps/forms/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:65395:18)
    at async CAC.<anonymous> (file:///var/www/html/apps/forms/node_modules/vite/dist/node/cli.js:829:5)

Any suggestions how to deal with it?

@Koc Koc mentioned this pull request Jan 29, 2025
Closed
@Koc Koc requested a review from Chartman123 January 29, 2025 16:05
@Koc
fix: Fix spreadsheet unlinking
ce208e2 
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
@Koc Koc force-pushed the bugfix/fix-file-unlink branch from 2e2adce to ce208e2 Compare January 29, 2025 16:06
@Chartman123 Chartman123 added bug Something isn't working javascript Javascript related ticket 3. to review Waiting for reviews labels Jan 29, 2025
@Chartman123 Chartman123 added this to the 5.0 milestone Jan 29, 2025
Chartman123
Chartman123 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :) I was also able to compile it, so probably something in your dev environment

@Chartman123 Chartman123 merged commit 6d40e08 into main Jan 29, 2025
47 checks passed
@Chartman123 Chartman123 deleted the bugfix/fix-file-unlink branch January 29, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Error unlinking spreadsheet
2 participants
@Koc @Chartman123