perf: Add index for group_folders table #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
icewind1991,
artonge and
come-nc
as code owners
provokateurin
force-pushed
the
perf/group_folders-table-index
branch
from
beabd4e to
201ece6
Compare
artonge
reviewed
Oct 29, 2024
provokateurin
force-pushed
the
perf/group_folders-table-index
branch
from
201ece6 to
60ff87b
Compare
artonge
approved these changes
Oct 29, 2024
artonge
reviewed
Oct 29, 2024
|
Not substantial performance improvements measured, we can still add it later if needed. |
|
There are instances with 10k+ groupfolders so having an index probably makes sense. |
|
Ok, then we can add it. I would have expected that there already is an index in case anyone already suffered performance problems from the lack of an index on the table. |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
come-nc
requested changes
Nov 5, 2024
come-nc
approved these changes
Jan 9, 2025
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
perf/group_folders-table-index
branch
from
8dd95d3 to
60ff84c
Compare
This was referenced Jan 9, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a lot of SELECTs on this table in the FolderManager, but there is actually no index on it at all. All SELECTs include all columns, so that's why I'm not adding one for folder_id only.
Usually not noticable when there aren't many groupfolders, but if you got a few then it can take a bit too long.