Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Fix select input color #3460

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(settings): Fix select input color #3460

merged 1 commit into from
Dec 4, 2024

Conversation

provokateurin
Copy link
Member

Fixes #3409

@provokateurin provokateurin added bug 3. to review Items that need to be reviewed labels Dec 4, 2024
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

artonge
artonge reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it white in the first place?

@provokateurin
Copy link
Member Author

The library has it's own styling which interferes with our styling, so we have to manually set the text color in order for it to be legible on the background.

@provokateurin provokateurin merged commit 2f2297c into master Dec 4, 2024
47 checks passed
@provokateurin provokateurin deleted the fix/settings/select-input-color branch December 4, 2024 13:49
This was referenced Dec 4, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed bug
Projects
None yet
Milestone
No milestone
2 participants
@provokateurin @artonge