-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename app to Team folders #3536
Conversation
6878d90
to
1c51f9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 1 detail: Unless it’s at the beginning of a sentence, "team" should be lowercase. It’s a basic English word and looks out of place otherwise. :)
Ok, I thought we were taking it as a proper noun like in "Team folder" 👍 |
Signed-off-by: provokateurin <[email protected]>
1c51f9c
to
d5e5d7a
Compare
Just like the Circles (Teams) app, a note about the rename in the Readme.md can't hurt:
|
This is huge, what is the project behind this? Is there any issue tracking some sort of unification of groups and teams? If it's only a rebranding without any other meaning, there is a massive risk of confusion in the NC ecosystem... |
The reason is that Circles was also renamed to Teams and the names should be aligned, but @sorbaugh or @jancborchardt should be able to tell you more about this. |
@Ornanovitch this is the general idea behind it nextcloud/server#49488 |
Closes #3524
I hope I found all the user-facing strings.
I also made the names for consistent, so all variations of "groupfolders", "group folders", "Group folders" and "Groupfolders" are just "Team folders" now.