Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename app to Team folders #3536

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

provokateurin
Copy link
Member

Closes #3524

I hope I found all the user-facing strings.
I also made the names for consistent, so all variations of "groupfolders", "group folders", "Group folders" and "Groupfolders" are just "Team folders" now.

@provokateurin provokateurin added the 3. to review Items that need to be reviewed label Jan 13, 2025
@provokateurin provokateurin force-pushed the chore/rename-team-folders branch from 6878d90 to 1c51f9c Compare January 13, 2025 10:06
openapi.json Outdated Show resolved Hide resolved
@provokateurin provokateurin requested a review from come-nc January 13, 2025 13:54
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 detail: Unless it’s at the beginning of a sentence, "team" should be lowercase. It’s a basic English word and looks out of place otherwise. :)

@provokateurin
Copy link
Member Author

Ok, I thought we were taking it as a proper noun like in "Team folder" 👍

@provokateurin provokateurin merged commit f7547c6 into master Jan 14, 2025
50 checks passed
@provokateurin provokateurin deleted the chore/rename-team-folders branch January 14, 2025 14:40
@solracsf
Copy link
Member

Just like the Circles (Teams) app, a note about the rename in the Readme.md can't hurt:

The app was formerly named circles which is still used as internal identifier a lot.

@Ornanovitch
Copy link

This is huge, what is the project behind this? Is there any issue tracking some sort of unification of groups and teams? If it's only a rebranding without any other meaning, there is a massive risk of confusion in the NC ecosystem...

@provokateurin
Copy link
Member Author

The reason is that Circles was also renamed to Teams and the names should be aligned, but @sorbaugh or @jancborchardt should be able to tell you more about this.

@marcoambrosini
Copy link
Member

@Ornanovitch this is the general idea behind it nextcloud/server#49488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String rename "Groupfolders" to "Team folders"
8 participants