Merge pull request #1427 from nextcloud/use-php-8-4

chore: Bump max-version of PHP to 8.4
nextcloud · Nov 26, 2024 · 63b5439 · 63b5439
2 parents ae0239a + 24c69e2
commit 63b5439
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/appinfo/info.xml b/appinfo/info.xml
@@ -26,7 +26,7 @@ The Notes app is a distraction free notes taking app for [Nextcloud](https://www
 	<repository type="git">https://github.com/nextcloud/notes.git</repository>
 	<screenshot small-thumbnail="https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes-thumbnail.jpg">https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes.png</screenshot>
 	<dependencies>
-		<php min-version="8.0" max-version="8.3"/>
+		<php min-version="8.0" max-version="8.4"/>
 		<nextcloud min-version="28" max-version="31"/>
 	</dependencies>
 	<repair-steps>

diff --git a/lib/AppInfo/DashboardWidget.php b/lib/AppInfo/DashboardWidget.php
@@ -98,7 +98,7 @@ public function getWidgetButtons(string $userId): array {
 	public function getItems(string $userId, ?string $since = null, int $limit = 7): array {
 		$notes = $this->notesService->getTopNotes($userId);
 		$notes = array_slice($notes, 0, $limit);
-		return array_map(function (Note $note) {
+		return array_values(array_map(function (Note $note): WidgetItem {
 			$excerpt = '';
 			try {
 				$excerpt = $note->getExcerpt();
@@ -109,7 +109,7 @@ public function getItems(string $userId, ?string $since = null, int $limit = 7):
 				? $this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg'))
 				: $this->getIconUrl();
 			return new WidgetItem($note->getTitle(), $excerpt, $link, $icon, (string)$note->getModified());
-		}, $notes);
+		}, $notes));
 	}
 
 	public function getIconUrl(): string {

diff --git a/lib/Service/TagService.php b/lib/Service/TagService.php
@@ -20,6 +20,10 @@ public function __construct(ITagManager $tagManager) {
 		$this->tagger = $tagManager->load('files');
 	}
 
+	/**
+	 * @param list<int> $fileIds
+	 * @return void
+	 */
 	public function loadTags(array $fileIds) : void {
 		$this->cachedTags = $this->tagger->getTagsForObjects($fileIds);
 	}