Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the welcome message paddings for mobile view #1425

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Adjust the welcome message paddings for mobile view #1425

merged 1 commit into from
Nov 27, 2024

Conversation

falghamdi125
Copy link
Contributor

☑️ Resolves

Hello everyone,

This PR makes adjustments to the padding of the welcome message div, specifically optimizing it for a better readability on mobile devices.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Best

enjeck
enjeck approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄 👍 , thank you!

@enjeck
Copy link
Contributor

enjeck commented Nov 26, 2024

@falghamdi125 Can you please sign off the commit? More info at https://github.com/nextcloud/notes/pull/1425/checks?check_run_id=33429321185

@juliusknorr juliusknorr added bug Something isn't working design Related to the design or user experience labels Nov 26, 2024
@falghamdi125 falghamdi125 force-pushed the adjust-welcome-message-padding-for-mobile branch 2 times, most recently from 3ea2507 to 602887f Compare November 26, 2024 14:02
@falghamdi125
Copy link
Contributor Author

Done! @enjeck

@enjeck
Copy link
Contributor

enjeck commented Nov 27, 2024 •
edited
Loading

@falghamdi125 Sorry, one more request. Can you please amend your commit message to be "fix: Adjust the welcome message paddings for mobile view". It seems we need to follow the Conventional Commits style to pass this CI test: https://github.com/nextcloud/notes/actions/runs/12032237238/job/33549108352?pr=1425

@falghamdi125 falghamdi125 force-pushed the adjust-welcome-message-padding-for-mobile branch from 602887f to 915bfe1 Compare November 27, 2024 02:38
@falghamdi125
Copy link
Contributor Author

@falghamdi125 Sorry, one more request. Can you please amend your commit message to be "fix: Adjust the welcome message paddings for mobile view". It seems we need to follow the Conventional Commits style to pass this CI test: https://github.com/nextcloud/notes/actions/runs/12032237238/job/33549108352?pr=1425

👍

@juliusknorr juliusknorr merged commit 7f0c590 into nextcloud:main Nov 27, 2024
29 checks passed
@juliusknorr
Copy link
Member

Thank you very much for your contribution @falghamdi125 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjeck enjeck enjeck approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter JuliaKirschenheuter is a code owner

Assignees
No one assigned
Labels
bug Something isn't working design Related to the design or user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falghamdi125 @enjeck @juliusknorr