fix: Avoid getting the file for storing settings #4529
Draft
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <[email protected]>
codewithvk
force-pushed
the
fix/settings-middleware-check
branch
from
98b7165 to
06e8fc1
Compare
codewithvk
reviewed
Feb 28, 2025
| @@ -60,6 +61,11 @@ public function beforeController($controller, $methodName) { | |||
| $accessToken = $this->request->getParam('access_token'); | |||
| [$fileId, ,] = Helper::parseFileId($fileId); | |||
| $wopi = $this->wopiMapper->getWopiForToken($accessToken); | |||
|
|
|||
| if ($wopi->getTokenType() === Wopi::TOKEN_TYPE_SETTING_AUTH) { | |||
There was a problem hiding this comment.
FYI: sometimes we can also send document tokens(type 0 in wopi) when we want to upload while the document is open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Knorr [email protected]
Summary
TODO
Checklist