-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(files_reminders): Reduce db queries on propfind #50244
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
f04cc38
to
17d93de
Compare
$fileIds = array_values(array_filter(array_map( | ||
function (Node $node) { | ||
try { | ||
return $node->getId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this can't throw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interface says it can?
server/lib/public/Files/Node.php
Lines 93 to 101 in 6907b62
/** | |
* Get the internal file id for the file or folder | |
* | |
* @return int | |
* @throws InvalidPathException | |
* @throws NotFoundException | |
* @since 6.0.0 | |
*/ | |
public function getId(); |
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
17d93de
to
7f72601
Compare
Summary
Checklist