Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): support submenu in batch actions header too #50364

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 23, 2025

Supersede #45525

image

Summary

  • Add support for subactions on the header
  • Fixed handling of actions and unified some processes between file actions and selection actions
  • Added cypress tests:
    • Standard file actions
    • Nested file actions
    • Selection file actions
    • Nested selection actions

@skjnldsv skjnldsv self-assigned this Jan 23, 2025
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 23, 2025
@skjnldsv skjnldsv force-pushed the fix/files-header-submenu branch 2 times, most recently from 07c66c5 to ed53b64 Compare January 24, 2025 13:17
@skjnldsv skjnldsv requested review from susnux, Pytal and artonge January 24, 2025 13:21
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jan 24, 2025
@skjnldsv
Copy link
Member Author

/backport to stable31

@skjnldsv skjnldsv force-pushed the fix/files-header-submenu branch from 8341866 to 137dbef Compare January 29, 2025 09:22
@skjnldsv skjnldsv force-pushed the fix/files-header-submenu branch from 137dbef to ca56f7a Compare February 6, 2025 14:29
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 6, 2025

/compile rebase-amend /

Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/files-header-submenu branch from 3e85503 to d8df001 Compare February 7, 2025 09:07
@skjnldsv skjnldsv enabled auto-merge February 7, 2025 09:18
@skjnldsv skjnldsv merged commit f21ffab into master Feb 7, 2025
120 checks passed
@skjnldsv skjnldsv deleted the fix/files-header-submenu branch February 7, 2025 09:20
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 7, 2025

/backport to stable31

Copy link

backportbot bot commented Feb 7, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/50364/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e10947a5 73e4a13a d8df001f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50364/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/50364/stable31."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants