nextcloud · blizzz · Jan 30, 2025 · Jan 29, 2025
diff --git a/version.php b/version.php
@@ -9,10 +9,10 @@
 // between betas, final and RCs. This is _not_ the public version number. Reset minor/patch level
 // when updating major/minor version number.
 
-$OC_Version = [31, 0, 0, 12];
+$OC_Version = [31, 0, 0, 13];
 
 // The human-readable string
-$OC_VersionString = '31.0.0 RC1';
+$OC_VersionString = '31.0.0 RC2';
 
 $OC_VersionCanBeUpgradedFrom = [
 	'nextcloud' => [

diff --git a/lib/private/App/InfoParser.php b/lib/private/App/InfoParser.php
 		}

 		libxml_use_internal_errors(true);
 		$xml = simplexml_load_string(file_get_contents($file));

 		if ($xml === false) {
 			libxml_clear_errors();
diff --git a/lib/private/AppFramework/Http/Dispatcher.php b/lib/private/AppFramework/Http/Dispatcher.php
 		}

 		$this->eventLogger->start('controller:' . get_class($controller) . '::' . $methodName, 'App framework controller execution');
 		$response = \call_user_func_array([$controller, $methodName], $arguments);
 		$this->eventLogger->end('controller:' . get_class($controller) . '::' . $methodName);

 		if (!($response instanceof Response)) {
diff --git a/lib/private/Installer.php b/lib/private/Installer.php

 	private static function includeAppScript(string $script): void {
 		if (file_exists($script)) {
 			include $script;
 		}
 	}
 }
diff --git a/lib/private/L10N/L10N.php b/lib/private/L10N/L10N.php
 	 * @return bool
 	 */
 	protected function load(string $translationFile): bool {
 		$json = json_decode(file_get_contents($translationFile), true);
 		if (!\is_array($json)) {
 			$jsonError = json_last_error();
 			\OCP\Server::get(LoggerInterface::class)->warning("Failed to load $translationFile - json error code: $jsonError", ['app' => 'l10n']);
diff --git a/lib/private/TaskProcessing/Manager.php b/lib/private/TaskProcessing/Manager.php
 				$task->setEndedAt(time());
 				$error = 'The task was processed successfully but the provider\'s output doesn\'t pass validation against the task type\'s outputShape spec and/or the provider\'s own optionalOutputShape spec';
 				$task->setErrorMessage($error);
 				$this->logger->error($error . ' Output was: ' . var_export($result, true), ['exception' => $e]);
 			} catch (NotPermittedException $e) {
 				$task->setProgress(1);
 				$task->setStatus(Task::STATUS_FAILED);
diff --git a/lib/private/legacy/OC_App.php b/lib/private/legacy/OC_App.php
 		\OC::$server->registerNamespace($app, $appNamespace);

 		if (file_exists($path . '/composer/autoload.php')) {
 			require_once $path . '/composer/autoload.php';
 		} else {
 			\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
 		}
	}

	libxml_use_internal_errors(true);
	$xml = simplexml_load_string(file_get_contents($file));
Check failure on line 38 in lib/private/App/InfoParser.php GitHub Actions / static-code-analysis-security TaintedFile `lib/private/App/InfoParser.php:38:50: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)`

	if ($xml === false) {
	libxml_clear_errors();
	}

	$this->eventLogger->start('controller:' . get_class($controller) . '::' . $methodName, 'App framework controller execution');
	$response = \call_user_func_array([$controller, $methodName], $arguments);
Check failure on line 200 in lib/private/AppFramework/Http/Dispatcher.php GitHub Actions / static-code-analysis-security TaintedCallable `lib/private/AppFramework/Http/Dispatcher.php:200:37: TaintedCallable: Detected tainted text (see https://psalm.dev/243)`
	$this->eventLogger->end('controller:' . get_class($controller) . '::' . $methodName);

	if (!($response instanceof Response)) {

	private static function includeAppScript(string $script): void {
	if (file_exists($script)) {
	include $script;
Check failure on line 587 in lib/private/Installer.php GitHub Actions / static-code-analysis-security TaintedInclude `lib/private/Installer.php:587:12: TaintedInclude: Detected tainted code passed to include or similar (see https://psalm.dev/251)`
	}
	}
	}
	* @return bool
	*/
	protected function load(string $translationFile): bool {
	$json = json_decode(file_get_contents($translationFile), true);
Check failure on line 215 in lib/private/L10N/L10N.php GitHub Actions / static-code-analysis-security TaintedFile `lib/private/L10N/L10N.php:215:41: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)`
	if (!\is_array($json)) {
	$jsonError = json_last_error();
	\OCP\Server::get(LoggerInterface::class)->warning("Failed to load $translationFile - json error code: $jsonError", ['app' => 'l10n']);
	$task->setEndedAt(time());
	$error = 'The task was processed successfully but the provider\'s output doesn\'t pass validation against the task type\'s outputShape spec and/or the provider\'s own optionalOutputShape spec';
	$task->setErrorMessage($error);
	$this->logger->error($error . ' Output was: ' . var_export($result, true), ['exception' => $e]);
Check failure on line 1002 in lib/private/TaskProcessing/Manager.php GitHub Actions / static-code-analysis-security TaintedHtml `lib/private/TaskProcessing/Manager.php:1002:64: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)`
	} catch (NotPermittedException $e) {
	$task->setProgress(1);
	$task->setStatus(Task::STATUS_FAILED);
	\OC::$server->registerNamespace($app, $appNamespace);

	if (file_exists($path . '/composer/autoload.php')) {
	require_once $path . '/composer/autoload.php';
Check failure on line 115 in lib/private/legacy/OC_App.php GitHub Actions / static-code-analysis-security TaintedInclude `lib/private/legacy/OC_App.php:115:17: TaintedInclude: Detected tainted code passed to include or similar (see https://psalm.dev/251)`
	} else {
	\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
	}