fix(files): attach sidebar to main content for vue debug #50814
+27
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
added
bug
feature: files
regression
feature: file sidebar
|
/backport 6c8c80d to stable30 |
|
/backport 6c8c80d to stable29 |
|
/backport to stable31 |
susnux
approved these changes
Feb 14, 2025
Yes, was a design request iirc Maybe check the behaviour with @marcoambrosini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50629
Regression from #37065
@Pytal since you did the other PR, I'm not sure what this was about.
On mount if there is none we don't show it, is that so?
I guess this have been replaced by #40939 as we now save the current show/hide state ?
Vue fix
First commit also fixes the undebuggable state of the sidebar in the vue dev tools 🥹
