Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue3] Migrate app to Vue3 #12458

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

[Vue3] Migrate app to Vue3 #12458

wants to merge 50 commits into from
+6,445 −6,741

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 4, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • Remote MediaStream doesn't shown - issue with reactivity
  • Mapping doesn't stop in the call - from vue3-shortkey, on LocalAudio/Video buttons - https://vueuse.org/core/onKeyStroke/
    image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Jun 4, 2024
@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jun 4, 2024
@Antreesy Antreesy requested review from ShGKme and DorraJaouad June 4, 2024 09:38
@Antreesy Antreesy self-assigned this Jun 4, 2024
@ShGKme ShGKme mentioned this pull request Jun 5, 2024
Draft
ShGKme added 20 commits July 9, 2024 11:52
@ShGKme @Antreesy
chore(vue3): migrate from vue-frag
4043d4d 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): migrate from vue-simple-portal
3f8860a 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(deps): remove unneeded in Vue 3 dependencies
e720792 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(deps): temporary remove @nextcloud/upload
152c5ae 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): temporary disable @nextcloud/upload
53b7398 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(deps): temporary remove @nextcloud/dialogs in Vue 3
1db476f 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - remove styles import
a644baa 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - remove imports
0e18233 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - replace showError
da06f9c 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - replace showSuccess
d0f7332 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - replace showWarning
7290147 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - replace showInfo
f99e4fc 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - replace showMessage
38c3df2 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - replace TOAST_*_TIMEOUT
46acc0c 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): @nextcloud/dialogs - remove FilePickerVue
6dc4259 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(deps): upgrade deps to Vue 3 versions
b76f4a0 
Signed-off-by: Grigorii K. Shartsev <[email protected]>

Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): migrate to Vue Router 4
d5c0dd8 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(vue3): migrate to Vuex 4
0fc73b3 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): migrate to @vue-leaflet/vue-leaflet
216b48b 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(vue3): migrate vue init
6f5dee2 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
ShGKme and others added 21 commits July 9, 2024 11:58
@ShGKme @Antreesy
chore(vue3): lint vue/v-on-event-hyphenation
1b0f2b7 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): lint vue/no-deprecated-destroyed-lifecycle
08bb514 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(vue3): lint vue/attributes-order
6125e9a 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme @Antreesy
chore(vue3): lint vue/custom-event-name-casing
c4470a0 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
chore(vue3): temporary disable nextcloud-vue-collections
4778ff2 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(style): don't pass data-theme-dark
fe882a5 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(NewConversationSetup): use a value passed from v-model
8b409e5 
Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme @Antreesy
chore(vue3): migrate async component registration and remove $children
1f63cdd 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@DorraJaouad @Antreesy
fix(vue3): keep wrapper in transition group for styles
d8e53a1 
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad @Antreesy
fix(vue3): remove not needed keys
186640c 
Signed-off-by: DorraJaouad <[email protected]>
@Antreesy
chore(vue3): migrate to ESLint with Vue 3 plugin
dec067c 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(jest): harden tests with object serializing
04eeaeb 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vue3): fix updated props and attributes
dc5ed8c 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vtu): replace propsData with props
2a97af1 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vtu): replace createLocalVue with plugins, use global mount object
95f8042 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vtu): fix find* utils usage
334fbcc 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vtu): fix text nodes and slots
39c499e 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vue3): fix double emitting
cbe4eb8 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vtu): skip tests for @netxcloud/dialogs and @nextcloud/upload
b71e6dc 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(vtu): replace flushPromises function
c8fef4c 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
chore(deps): remove "flush-promises" library
87a3027 
Signed-off-by: Maksim Sukharev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client
Projects
💬 Talk team
Status: 🏗️ In progress
Milestone
🌿 Next Beta (31)
Development

Successfully merging this pull request may close these issues.
5 participants
@Antreesy @nickvergessen @danxuliu @ShGKme @DorraJaouad