Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate certificateService to ts #13876

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 26, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy Antreesy force-pushed the fix/noid/certificate-service-ts branch from 20fa564 to af7f428 Compare January 30, 2025 12:53
@Antreesy Antreesy requested a review from DorraJaouad January 30, 2025 12:53
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise

@Antreesy Antreesy merged commit 9815309 into main Jan 30, 2025
54 checks passed
@Antreesy Antreesy deleted the fix/noid/certificate-service-ts branch January 30, 2025 13:31
@Antreesy
Copy link
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants