Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Screen): allow to zoom and pan screenshare content #14028

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat(Screen): allow to zoom and pan screenshare content #14028

merged 2 commits into from
Jan 17, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 19, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image
2025-01-16_13h02_45.mp4

🚧 Tasks

  • Fix styles
  • Apply constraints
  • Check with VideoVue component (if needed)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 19, 2024
@Antreesy Antreesy self-assigned this Dec 19, 2024
@nickvergessen
Copy link
Member

Looks good on a first glance 👍

@Antreesy Antreesy force-pushed the feat/12187/zoom-in-screenshare branch from 3330e9c to 107c559 Compare December 23, 2024 12:44
@Antreesy Antreesy changed the base branch from main to fix/12187/presenter-overlay-borders December 23, 2024 12:44
@Antreesy Antreesy marked this pull request as ready for review December 23, 2024 15:06
@Antreesy Antreesy force-pushed the fix/12187/presenter-overlay-borders branch from 9c95b70 to d6eeb98 Compare December 23, 2024 22:18
@DorraJaouad DorraJaouad self-requested a review January 6, 2025 08:19
Base automatically changed from fix/12187/presenter-overlay-borders to main January 10, 2025 16:17
@Antreesy Antreesy force-pushed the feat/12187/zoom-in-screenshare branch from 107c559 to de77116 Compare January 10, 2025 17:02
@Antreesy Antreesy force-pushed the feat/12187/zoom-in-screenshare branch from de77116 to 42e62b9 Compare January 16, 2025 11:59
@Antreesy Antreesy requested a review from ShGKme January 16, 2025 12:03
@Antreesy Antreesy added 3. to review feature: call 📹 Voice and video calls and removed 2. developing labels Jan 16, 2025
@Antreesy Antreesy merged commit aa9a3f9 into main Jan 17, 2025
50 checks passed
@Antreesy Antreesy deleted the feat/12187/zoom-in-screenshare branch January 17, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🌿 Next Beta (31)
Development

Successfully merging this pull request may close these issues.

Zoom and pan on received screen share when larger than the available space to view it
4 participants
@Antreesy @nickvergessen @ShGKme @DorraJaouad