Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Fix protocol handling of invitations #14141

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 16, 2025

Invitations are always stored with the protocol,
so when checking for invitations we use the original remoteServerUrl
which contains the protocol in http and https cases

πŸ› οΈ API Checklist

🚧 Tasks

  • Test federation with https in both directions (main being sender and receiver)
  • No integration test possible while https is not supported there

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

Invitations are always stored with the protocol,
so when checking for invitations we use the original remoteServerUrl
which contains the protocol in http and https cases

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-federation-from-main-to-other branch from 6dd1cc1 to 4ea7001 Compare January 16, 2025 13:17
@miaulalala miaulalala merged commit eb3e20a into main Jan 16, 2025
75 checks passed
@miaulalala miaulalala deleted the bugfix/noid/fix-federation-from-main-to-other branch January 16, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants