fix: user contacts menu instead of conversation participants (there c… #14143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould be users who left) Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
DorraJaouad
added
enhancement
feature: chat 💬
| */ | ||
| async function fetchContacts(searchTerm: string = '') { | ||
| try { | ||
| const { data: { contacts } } = await getContacts(searchTerm) |
There was a problem hiding this comment.
Ah, this is what Maksim had asked me. Hmm using contacts is quite bad for multiple reasons:
- It's limited by share restrictions, so you might not even see everyone that is in the room
- Guests, federated users, emails, … are not supported
I would stay with the current participants for now. As a follow up I would then as a replacement create a new API endpoint which provides the information that you need for all message authors instead?
There was a problem hiding this comment.
Better to do it together with messages/search endpoint then, since UnifiedSearch provider is also blocking guests, federated users, e.t.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Recording.2025-01-16.200647.mp4
🏁 Checklist
…ould be users who left)