Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setupcheck): Downgrade setup check when warning opt-out is used #14147

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(setupcheck): Downgrade setup check when warning opt-out is used #14147

merged 1 commit into from
Jan 17, 2025

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 17, 2025
@nickvergessen nickvergessen added this to the 🌿 Next Beta (31) milestone Jan 17, 2025
@nickvergessen nickvergessen self-assigned this Jan 17, 2025
Antreesy
Antreesy approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@scubamuc scubamuc mentioned this pull request Jan 17, 2025
Merged
@nickvergessen nickvergessen merged commit 5ce4f45 into main Jan 17, 2025
73 of 75 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/downgrade-setupcheck branch January 17, 2025 11:51
@nickvergessen
Copy link
Member Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Jan 17, 2025
Merged
@scubamuc scubamuc mentioned this pull request Feb 26, 2025
Open
@scubamuc
Copy link

@nickvergessen initial tests for Nextcloud snap Hub 10, message for missing HPB returns:

nextcloud-snap/nextcloud-snap#3068 (comment)

@Antreesy
Copy link
Contributor

message for missing HPB returns:

It should be 'info' level now, if "Warn about ...' is toggled off in administration settings, and 'error', if not

https://github.com/nextcloud/spreed/blob/9facfc1b779304b0a9bf4789f17680c4090ee274/lib/SetupCheck/HighPerformanceBackend.php#L43C1-L45C5

image

@scubamuc
Copy link

@Antreesy thanks for your quick reply

these are early tests...
fresh install, no settings no configurations, just fresh install
but the message is red and concerting:

grafik

nextcloud-snap/nextcloud-snap#3068 (comment)

@Antreesy
Copy link
Contributor

If I'm not mistaken, we decided to emphasize that for all instances, as:

  • some exisitng features of Talk rely on HPB (e.g. breakout rooms) and won't work without it
  • calls are not scalable without HPB
  • performance in general is degrading without HPB (e.g. interval polling instead of update via signaling messages)
  • we plan to develop new features and improve performance further heavily using HPB
  • there are now community and enterprise instructions on how to install HPB (thanks to nextcloud-snap devs)
  • most important - warning can now be turned off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
v21.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @scubamuc @Antreesy