Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AdminSettings): move signaling state to the root #14149

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(AdminSettings): move signaling state to the root #14149

wants to merge 3 commits into from
+183 −192

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🚧 Tasks

  • Move current components to TS (2/17)
  • replace EventBus.emit('signaling-servers-updated'), with reactive state

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy Antreesy added this to the 🌿 Next Beta (31) milestone Jan 17, 2025
@Antreesy Antreesy self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review feature: settings ⚙️ Settings and config related issues technical debt
Projects
None yet
Milestone
🌿 Next Beta (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen