fix(SpeakingWhileMutedWarner): show warning in the popup #14152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
|
backport to stable30 |
ShGKme
reviewed
Jan 17, 2025
| @@ -182,6 +194,7 @@ export default { | |||
| data() { | |||
| return { | |||
| screenSharingMenuOpen: false, | |||
| speakingWhileMutedWarner: null, | |||
There was a problem hiding this comment.
Instead of mounted, if it doesn't require the button bar to be mounted to DOM.
Then no need for second re-render after mounting from ?.
Suggested change
| speakingWhileMutedWarner: null, | |
| speakingWhileMutedWarner: new SpeakingWhileMutedWarner(this.model), |
Comment on lines
+46
to
+61
| <NcPopover :boundary="boundaryElement" | ||
| :show-triggers="[]" | ||
| :hide-triggers="['click']" | ||
| :auto-hide="false" | ||
| :focus-trap="false" | ||
| :shown="speakingWhileMutedWarner?.showPopup"> | ||
| <template #trigger> | ||
| <LocalAudioControlButton :token="token" | ||
| :conversation="conversation" | ||
| :model="model" | ||
| type="tertiary" /> | ||
| </template> | ||
| <div class="hint"> | ||
| <span>{{ speakingWhileMutedWarner?.message }}</span> | ||
| </div> | ||
| </NcPopover> |
There was a problem hiding this comment.
What about viewer overlay? Maybe make it a part of the LocalAudioControlButton?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist