Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChatView): center dragover on MessagesList only #14237

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(ChatView): center dragover on MessagesList only #14237

merged 1 commit into from
Jan 28, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 27, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Jan 27, 2025
@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Jan 27, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy January 27, 2025 21:48
@DorraJaouad DorraJaouad self-assigned this Jan 27, 2025
Antreesy
Antreesy approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with current implementation, but see comment

src/components/ChatView.vue Outdated Show resolved Hide resolved
@Antreesy
Copy link
Contributor

/backport to stable31

@Antreesy Antreesy merged commit db91e82 into main Jan 28, 2025
50 checks passed
@Antreesy Antreesy deleted the fix/noid/dragover branch January 28, 2025 16:12
@backportbot backportbot bot mentioned this pull request Jan 28, 2025
Merged
@DorraJaouad DorraJaouad mentioned this pull request Jan 31, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @Antreesy