Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessagesList): keep chat at the bottom when list height is changing #14266

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix(MessagesList): keep chat at the bottom when list height is changing #14266

merged 2 commits into from
Jan 31, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

Fix breaking the list scrolling when input height changes from:

  • multiline message
  • reply to
  • typing indicator
  • e.t.c.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before

2025-01-31_12h41_27.mp4

🏡 After

2025-01-31_12h40_27.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Jan 31, 2025
@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jan 31, 2025
@Antreesy Antreesy requested a review from DorraJaouad January 31, 2025 11:42
@Antreesy Antreesy self-assigned this Jan 31, 2025
DorraJaouad
DorraJaouad approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't break anything so far :D

@Antreesy Antreesy merged commit b5fedb1 into main Jan 31, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/message-list-sticky branch January 31, 2025 14:55
@Antreesy
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot mentioned this pull request Jan 31, 2025
Merged
This was referenced Feb 3, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad