-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep layout on sync errors #6903
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6903 +/- ##
==========================================
+ Coverage 37.84% 37.86% +0.01%
==========================================
Files 750 740 -10
Lines 42664 42642 -22
Branches 1273 1263 -10
==========================================
Hits 16146 16146
+ Misses 25896 25884 -12
+ Partials 622 612 -10 โ View full report in Codecov by Sentry. |
af40cfd
to
d9d2506
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @max-nextcloud, let's just make sure that the margin from the bottom is of size --clickable-area
bff0826
to
adc0bdb
Compare
/backport to stable30 |
/backport to stable29 |
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
adc0bdb
to
f14eb27
Compare
@marcoambrosini I noticed an issue with the layout: Possible solutionsLeave some room for the scrollbarI can work around this by making the message Use flex column layout on the parentThis way the message is on the bottom and the room above is for the text content. I'm not sure which one to pick. |
Did you try to play with the z-index of the element? Seems strange that it ends up above the scrollbar |
Yes. Changed it from the current 100.000 to 0 without any effect. |
@ShGKme do you have any idea why that happens? |
See #6877
Ui changes
๐ผ๏ธ Screenshots
Other commits
โ๏ธ TODO
--clickable-area