[stable30] fix: Hide download action when file does not provide download permissions #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
bug
|
@skjnldsv can we merge this, please? 🙏 |
Koc
force-pushed
the
backport/2482/stable30
branch
from
aa25311 to
bb910fa
Compare
Koc
force-pushed
the
backport/2482/stable30
branch
from
bb910fa to
c0d4d62
Compare
|
I've tested it, it works in general. The only one thing - we should update import in |
Koc
force-pushed
the
backport/2482/stable30
branch
from
c0d4d62 to
d81ceef
Compare
…ions This is not only a possibility for public shares but also for internal shares, the current code only "checked" public shares. This adds the same logic we use in the files app. Probably something to move to `@nextcloud/sharing` but for the moment lets just reuse here. Signed-off-by: Ferdinand Thiessen <[email protected]> [skip ci]
backportbot
bot
force-pushed
the
backport/2482/stable30
branch
from
d81ceef to
56ab62b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@susnux mind fixing the conflicts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2482
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.