Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Winnow 0.7 #2109

Merged
merged 4 commits into from
Jan 30, 2025
Merged

chore: Upgrade to Winnow 0.7 #2109

merged 4 commits into from
Jan 30, 2025

Conversation

epage
Copy link
Contributor

@epage epage commented Jan 30, 2025

With 0.7, ErrMode is optional. It looks like cut_err isn't used but I held off on migrating from ModalResult to winnow::Result and ModalParser to Parser in case there is a future possibility of using ErrMode.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (5329ab9) to head (5b9f170).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2109   +/-   ##
=======================================
  Coverage   80.05%   80.06%           
=======================================
  Files         102      102           
  Lines       24117    24121    +4     
=======================================
+ Hits        19308    19313    +5     
+ Misses       4809     4808    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunshowers
Copy link
Member

Thanks! Yeah, I think preserving the ability to do backtracks and cuts is useful.

(btw a small bit of doc feedback, https://docs.rs/winnow/latest/winnow/error/enum.ErrMode.html could make it a little clearer that "modal parsing" means, specifically, that more than one kind of error can happen during parsing. Had to read https://docs.rs/winnow/latest/winnow/_tutorial/chapter_7/index.html#error-cuts to understand that.)

@sunshowers sunshowers merged commit a734cf2 into nextest-rs:main Jan 30, 2025
20 checks passed
@epage epage deleted the w7 branch January 30, 2025 20:53
@epage
Copy link
Contributor Author

epage commented Jan 30, 2025

Docs PR is up at winnow-rs/winnow#733. If you could let me know if that does a sufficient job clarifying things, that'd be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants