[nextest-runner] detect host platform via rustc -vV #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in support for parsing `rustc -vV` output.
0.4.24 was yanked.
sunshowers
force-pushed
the
host-platform-vv
branch
from
e162b08 to
ed5c1d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
+ Coverage 80.08% 80.12% +0.04%
==========================================
Files 102 103 +1
Lines 24139 24343 +204
==========================================
+ Hits 19331 19505 +174
- Misses 4808 4838 +30 ☔ View full report in Codecov by Sentry. |
In some cases, such as using a musl binary on a GNU-based Linux, we should return `x86_64-unknown-linux-gnu`, not `-musl`. Continue to fall back to the build target, and produce an error if both methods fail.
sunshowers
force-pushed
the
host-platform-vv
branch
from
ed5c1d1 to
4bc7614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, like running musl binaries against GNU-based rustc, we should return
-gnu, not-musl.Fixes #2124.