Adds fallback for OSRM "NoRoute" errors #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merschformann
requested review from
cowanwalls,
sebastian-quintero and
nmisek
nilsbeck
approved these changes
Oct 24, 2024
nextplot/osrm.py
Outdated
| ) | ||
| distances.append(common.haversine(f, t)) | ||
| durations.append(common.haversine(f, t) / TRAVEL_SPEED) | ||
| return OsrRouteResponse(paths=paths, distances=distances, durations=durations, no_route=True) |
| @@ -40,9 +41,26 @@ def query_route( | |||
| # Query OSRM | |||
| try: | |||
| response = requests.get(url) | |||
| # If no route was found, use as-the-crow-flies fallback | |||
| if response.status_code == 400 and response.json()["code"] == "NoRoute": | |||
There was a problem hiding this comment.
if it was a "bad request" why not always fall back?
There was a problem hiding this comment.
Fair point. 🤔
I think the reason here is that it will likely fall back for all routes, which might be worse. 🤔
There was a problem hiding this comment.
I think I will leave it like it for now. Let's see whether we want to change this in future.
sebastian-quintero
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fallback mechanism for when OSRM fails to find a route, alongside improved error handling.
Changes