Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of nf-gpt into crisprseq pipeline. #193

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

LeonHornich
Copy link

@LeonHornich LeonHornich commented Sep 2, 2024

This is a very early stage implementation of the nf-gpt plugin into the pipeline. It can currently handles a list of genes extracted from the drugZ, bagel2 or mle module output and parses it to the plugin.

You can run the changes using:
export OPENAI_API_KEY=your-api-key
nextflow run . -profile test_screening,docker --outdir test -dump-channels --gpt_interpretation drugz,mle,bagel2,rra -resume

DISCLAIMER! You will need a functioning Open AI api key. for this to work.

Since this is very early version and only comes with the bare minimum of functionality there are a lot of adjustment that have to me made:

  • add option to generate multiple different responses per model and query.

Keep in mind this implementation does not aim to achieve 100% correct results from the gpt model, but instead is to build a foundational implementation for (future) LLMs into a nf-core pipeline.

If you have any suggestions or requested changes please let me know and i will try to adjust the code.

Copy link

github-actions bot commented Sep 2, 2024

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@LaurenceKuhl LaurenceKuhl changed the base branch from master to dev September 2, 2024 11:38
Copy link

github-actions bot commented Sep 2, 2024

nf-core lint overall result: Failed ❌

Posted for pipeline commit 05c4d56

+| ✅ 235 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!
-| ❌   1 tests failed       |-

❌ Test failures:

  • actions_ci - Minimum pipeline NF version '23.04.0' is not tested in '.github/workflows/ci.yml'

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.3.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: conf/test.config
  • files_exist - File is ignored: conf/test_full.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-19 11:53:17

@LeonHornich
Copy link
Author

Hi @LaurenceKuhl do you know if someone can help me out with this? I still think that the template update messed up some things and I have been unable to get the pr back up and running. The gpt implementation seems to not be the cause and the fork contains some error which I am having trouble fixing as it points to files all over the pipeline. If you don't have the time that's also no problem 😄

@mirpedrol
Copy link
Member

Hello @LeonHornich, the changes in the dev branch replaced nf-validation by nf-schema, when resolving the conflicts while merging dev to this PR some duplications were added (see https://github.com/nf-core/crisprseq/pull/193/files#diff-61ea3cf4e947c6ba28f51817a80d81e89b8f806db0de65d874149cc075ac3c6dR47 for example).
I haven't checked if there are more of this errors, but you can go through the code changes and make sure that we are only using nf-schema now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants