Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hitselection code and acknowledgement #222

Merged
merged 10 commits into from
Feb 27, 2025
Merged

Conversation

metinyazar
Copy link

PR checklist

  • [x ] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/crisprseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Jan 20, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@mirpedrol mirpedrol changed the base branch from master to dev January 20, 2025 14:49
@mirpedrol
Copy link
Member

Hi @metinyazar, I changed the target branch to dev.
Your branch is outdated so you will have to update it either from the button "Update branch" at the bottom this PR, or by running git pull upstream dev on your fork.
Let's see if tests pass after this 🙂

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@LaurenceKuhl
Copy link
Contributor

Hi @metinyazar,

should we merge the PR ? :)

@metinyazar
Copy link
Author

Hi, I am not sure about merging 😅 but I wrote it according to last version. If you think to go live maybe we can make littile arrangements and improvements too

@LaurenceKuhl
Copy link
Contributor

I think you could update the changelog to describe your new implementation and improvements and if the tests pass we should be good to go

@mirpedrol
Copy link
Member

is it ok if I merge this PR?

@mirpedrol
Copy link
Member

I am going to merge it, as I think it's done. Shout if it's not ready, and we can always revert or open a follow-up PR. Thaks!

@mirpedrol mirpedrol merged commit 1747d5d into nf-core:dev Feb 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants