-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New hitselection code and acknowledgement #222
Conversation
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
Hi @metinyazar, I changed the target branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hi @metinyazar, should we merge the PR ? :) |
Hi, I am not sure about merging 😅 but I wrote it according to last version. If you think to go live maybe we can make littile arrangements and improvements too |
I think you could update the changelog to describe your new implementation and improvements and if the tests pass we should be good to go |
is it ok if I merge this PR? |
I am going to merge it, as I think it's done. Shout if it's not ready, and we can always revert or open a follow-up PR. Thaks! |
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).