Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new parameters added to the trimming commands #237

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

matbonfanti
Copy link

@matbonfanti matbonfanti commented Mar 6, 2025

This PR implements a new feature I requested in issue #231, introducing parameters that allow specifying additional arguments for the cutadapt command line.

Two separate parameters are provided: one for 5' trimming and one for 3' trimming, as trimming requirements for each read end may vary depending on the experimental setup.

Marking this PR as draft, as further work is needed to:

  • Test the implementation
  • Update the parameter schema

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/crisprseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matbonfanti matbonfanti marked this pull request as draft March 6, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant