Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include affy timeout fix #210

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Include affy timeout fix #210

merged 4 commits into from
Dec 4, 2023

Conversation

pinin4fjords
Copy link
Member

Include nf-core/modules#4523

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the nf-core/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit cf71f42

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-12-04 10:06:05

@pinin4fjords pinin4fjords changed the base branch from master to dev December 1, 2023 14:49
@pinin4fjords pinin4fjords requested a review from WackerO December 1, 2023 14:50
@pinin4fjords
Copy link
Member Author

Thanks @WackerO !

@pinin4fjords pinin4fjords merged commit b7c822a into dev Dec 4, 2023
14 checks passed
@pinin4fjords pinin4fjords deleted the include_affy_fix branch December 4, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WackerO WackerO WackerO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @WackerO