Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot samtools view stub tests in data path conversion #4926

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Forgot samtools view stub tests in data path conversion #4926

merged 1 commit into from
Feb 15, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@maxulysse maxulysse marked this pull request as ready for review February 15, 2024 16:33
@maxulysse maxulysse changed the title Update main.nf.test Forgot samtools view stub tests data path conversion Feb 15, 2024
@maxulysse maxulysse changed the title Forgot samtools view stub tests data path conversion Forgot samtools view stub tests in data path conversion Feb 15, 2024
@maxulysse maxulysse enabled auto-merge February 15, 2024 17:02
asp8200
asp8200 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try that.

@maxulysse maxulysse added this pull request to the merge queue Feb 15, 2024
Merged via the queue into master with commit 0bd7d23 Feb 15, 2024
11 checks passed
@maxulysse maxulysse deleted the maxulysse-patch-1-1 branch February 15, 2024 17:07
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
@maxulysse @jch-13
Forgot samtools view stub tests in data path conversion (nf-core#4926)
0eac6c2 
Update main.nf.test
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@maxulysse @jennylsmith
Forgot samtools view stub tests in data path conversion (nf-core#4926)
c2dfdbb 
Update main.nf.test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

@priyanka-surana priyanka-surana Awaiting requested review from priyanka-surana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @asp8200