Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hard coded key prefix for schema in launcher #3432

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

remove hard coded key prefix for schema in launcher #3432

wants to merge 4 commits into from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 28, 2025

Fixes #3222

@mashehu mashehu requested a review from mirpedrol January 28, 2025 16:37
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (0ede9d5) to head (717a0bb).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/launch.py 0.00% 13 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu changed the title remove hard coded key prefix in schema remove hard coded key prefix for schema in launcher Jan 29, 2025
@mashehu
Copy link
Contributor Author

mashehu commented Jan 29, 2025

@nf-core-bot changelog

mirpedrol
mirpedrol approved these changes Jan 29, 2025
View reviewed changes
nf_core/pipelines/launch.py Outdated Show resolved Hide resolved
nf_core/pipelines/launch.py Outdated Show resolved Hide resolved
nf_core/pipelines/launch.py Outdated Show resolved Hide resolved
@mashehu @mirpedrol
Apply suggestions from code review
0265b61 
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot