Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format name/value with YAML syntax #3442

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

matbonfanti
Copy link

@matbonfanti matbonfanti commented Feb 3, 2025

This PR fixes the incorrect formatting of the params file generated by the nf-core pipelines create-params-file command (issue #3441). The output written with the name = value format has been corrected to name: value.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

nf_core/pipelines/params_file.py Show resolved Hide resolved
tests/pipelines/test_params_file.py Show resolved Hide resolved
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (639e419) to head (02dcbb7).
Report is 4 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbonfanti
Copy link
Author

@mashehu, if you think that all is fine with the code changes, can you please merge the PR?

@mashehu
Copy link
Contributor

mashehu commented Feb 6, 2025

I added you to the nf-core org, so you should have rights to merge the PR yourself and don't need to wait on me 🙂

@matbonfanti
Copy link
Author

awesome! thanks!

@matbonfanti matbonfanti merged commit 1f84814 into nf-core:dev Feb 6, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants