Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete formulas in altlabel & remove some questionable alternate labels #138

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

dalito
Copy link
Member

@dalito dalito commented Feb 4, 2025

We had some concepts having an Excel formula expression as as alternate label. This PR removes them. Strange how they got in.

This also removes some questionable alternate labels from the first phase of voc4cat which are more related concepts than alternate labels.

@dalito dalito force-pushed the fix_formula_in_altlabels branch from 589797c to 5020a5d Compare February 4, 2025 17:58
@dalito dalito added bug Something is not working as expected. enhancement Request for changing or improving existing features labels Feb 4, 2025
@dalito dalito force-pushed the fix_formula_in_altlabels branch from 5020a5d to 9e12a04 Compare February 4, 2025 18:10
@dalito dalito self-assigned this Feb 4, 2025
Copy link
Collaborator

@nmoust nmoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalito : Thank you for the changes. All changes are reasonable.

@dalito dalito merged commit 3918f9f into main Feb 5, 2025
1 check passed
@dalito dalito deleted the fix_formula_in_altlabels branch February 5, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected. enhancement Request for changing or improving existing features
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants