Handle StopTunnel request #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobzilladev
force-pushed
the
bob/burn-notice
branch
4 times, most recently
from
8b1c774
to
56dcb5e
Compare
bobzilladev
force-pushed
the
bob/burn-notice
branch
from
56dcb5e
to
4255808
Compare
There was a problem hiding this comment.
Overall approach looks good, but I think we should remove the public-facing CloseTunnel method as well as the user-definable StopTunnel handler.
Still need to go through the internal agent change to see how we're actually using it. Might have some suggestions there.
bobzilladev
force-pushed
the
bob/burn-notice
branch
from
60744f5
to
80f91bb
Compare
jrobsonchase
approved these changes
Nov 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle a new
StopTunnelmessage, which will close the tunnel, causing an error on the tunnel'sAccept(), and maintain the running session.