Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update doc links #121

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Add and update doc links #121

merged 2 commits into from
Nov 1, 2023

Conversation

jrobsonchase
Copy link
Collaborator

@jrobsonchase jrobsonchase commented Oct 26, 2023

More or less the same change as ngrok/ngrok-go#133.

Add the final destination links. I'll run a permalinking script after we've
agreed on the permalinks themselves. Per the updates in ngrok/ngrok-go#133, Product will handle the redirects, and these links are final.

@jrobsonchase
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Contributor

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All links correspond and successful. One comment about an old copy pasta, otherwise lgtm

ngrok/src/config/http.rs Outdated Show resolved Hide resolved
@jrobsonchase jrobsonchase merged commit e71d166 into main Nov 1, 2023
11 checks passed
@jrobsonchase jrobsonchase deleted the josh/doc-links branch November 1, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants