Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): complete dispatched$ in internal actions #2285

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Dec 23, 2024

We complete the dispatched$ subject within the internal actions once the application is destroyed
to ensure there are no active subscribers after resources have been cleaned up.

We complete the `dispatched$` subject within the internal actions once the application is destroyed
to ensure there are no active subscribers after resources have been cleaned up.
@arturovt arturovt force-pushed the fix/complete-dispatched branch from a08c249 to dbec7c6 Compare December 23, 2024 11:55
Copy link

nx-cloud bot commented Dec 23, 2024

View your CI Pipeline Execution ↗ for commit dbec7c6.

Command Status Duration Result
nx run-many --target=test --all --configuration... ❌ Failed 2m 20s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 7s View ↗
nx run-many --target=build --all ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-23 12:02:00 UTC

Copy link

pkg-pr-new bot commented Dec 23, 2024

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2285

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2285

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2285

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2285

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2285

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2285

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2285

commit: dbec7c6

Copy link

bundlemon bot commented Dec 23, 2024

BundleMon

Files updated (1)
Status Path Size Limits
fesm2022/ngxs-store.mjs
104.65KB (+127B +0.12%) 105KB / +0.5%
Unchanged files (5)
Status Path Size Limits
fesm2022/ngxs-store-internals.mjs
11.51KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
6.8KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.38KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

Total files change +127B +0.09%

Groups updated (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
31.89KB (+38B +0.12%) +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 23, 2024

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
4.03KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
3.01KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.61KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.57KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.46KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.14KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.01KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
861B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
396B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
20.05KB +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 23, 2024

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
+66.39KB +1%
Files removed (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
-70.1KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
-68.24KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
-67.3KB +1%

Total files change -139.25KB -67.71%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt marked this pull request as ready for review December 23, 2024 14:31
@arturovt arturovt merged commit 2b2cb76 into master Dec 23, 2024
14 of 15 checks passed
@arturovt arturovt deleted the fix/complete-dispatched branch December 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant