Fix ByCode OneToOne XML serialization (#3613)

src/NHibernate.Test/NHSpecificTest/GH3607/FixtureByCode.cs

@@ -0,0 +1,31 @@
+using NHibernate.Cfg;
+using NHibernate.Cfg.MappingSchema;
+using NHibernate.Mapping.ByCode;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	/// <summary>
+	/// By code mapping serialization failure since v5.4.1. Adapted from <see href="https://github.com/craigfowler/NHibernate.XmlConversionBug" />.
+	/// </summary>
+	[TestFixture]
+	public class FixtureByCode : TestCaseMappingByCode
+	{
+		protected override HbmMapping GetMappings()
+		{
+			var mapper = new ModelMapper();
+			mapper.AddMappings(new[] { typeof(OrderMapping), typeof(LineItemMapping), typeof(LineItemDataMapping) });
+			return mapper.CompileMappingForAllExplicitlyAddedEntities();
+		}
+
+		[Test]
+		public void SerializeMappingToXml()
+		{
+			var mapping = GetMappings();
+			string serialized = "";
+			Assert.That(() => serialized = mapping.AsString(), Throws.Nothing, "Mapping serialization failure");
+			var config = new Configuration();
+			Assert.That(() => config.AddXml(serialized), Throws.Nothing, "Configuration with serialized mapping has failed");
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3607/LineItem.cs

@@ -0,0 +1,15 @@
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	public class LineItem
+	{
+		public virtual int Id { get; set; }
+
+		public virtual Order ParentOrder { get; set; }
+
+		public virtual string ItemName { get; set; }
+
+		public virtual decimal Amount { get; set; }
+
+		public virtual LineItemData Data { get; set; }
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3607/LineItemData.cs

@@ -0,0 +1,9 @@
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	public class LineItemData
+	{
+		public virtual LineItem LineItem { get; set; }
+
+		public virtual string Data { get; set; }
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3607/LineItemDataMapping.cs

@@ -0,0 +1,14 @@
+using NHibernate.Mapping.ByCode.Conformist;
+
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	public class LineItemDataMapping : ClassMapping<LineItemData>
+	{
+		public LineItemDataMapping()
+		{
+			OneToOne(x => x.LineItem, m => m.Constrained(true));
+
+			Property(x => x.Data);
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3607/LineItemMapping.cs

@@ -0,0 +1,21 @@
+using NHibernate.Mapping.ByCode;
+using NHibernate.Mapping.ByCode.Conformist;
+
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	public class LineItemMapping : ClassMapping<LineItem>
+	{
+		public LineItemMapping()
+		{
+			Id(x => x.Id, m => m.Generator(new IdentityGeneratorDef()));
+
+			Property(x => x.ItemName);
+
+			Property(x => x.Amount);
+
+			ManyToOne(x => x.ParentOrder);
+
+			ManyToOne(x => x.Data);
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3607/Order.cs

@@ -0,0 +1,14 @@
+using System;
+using System.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	public class Order
+	{
+		public virtual int Id { get; set; }
+
+		public virtual DateTime CreatedDate { get; set; }
+
+		public virtual ISet<LineItem> Items { get; protected set; } = new HashSet<LineItem>();
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3607/OrderMapping.cs

@@ -0,0 +1,22 @@
+using NHibernate.Mapping.ByCode;
+using NHibernate.Mapping.ByCode.Conformist;
+
+namespace NHibernate.Test.NHSpecificTest.GH3607
+{
+	public class OrderMapping : ClassMapping<Order>
+	{
+		public OrderMapping()
+		{
+			Table("`Order`");
+			Id(x => x.Id, m => m.Generator(new IdentityGeneratorDef()));
+
+			Property(x => x.CreatedDate);
+
+			Set(x => x.Items, m =>
+			{
+				m.Inverse(true);
+				m.OptimisticLock(true);
+			}, a => a.OneToMany());
+		}
+	}
+}

src/NHibernate/Cfg/MappingSchema/HbmOneToOne.cs

@@ -18,9 +18,13 @@ public string Access
 			get { return access; }
 		}
 
+		// 6.0 Todo : remove XmlIgnore after removing the setter. See #3607 fix.
+		[XmlIgnore]
 		public bool OptimisticLock
 		{
 			get => optimisticlock;
+			// Since v5.4.10
+			[Obsolete("Providing a setter for OptimisticLock was unintended and will be removed.")]
 			set => optimisticlock = value;
 		}