-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH3530: Add locale specific tests to check for invalid type conversions. #3548
Open
deAtog
wants to merge
54
commits into
nhibernate:master
Choose a base branch
from
deAtog:GH-3530
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deAtog
force-pushed
the
GH-3530
branch
8 times, most recently
from
May 15, 2024 17:33
db08376
to
59b82e0
Compare
deAtog
changed the title
WIP - GH3530: Add locale specific tests to check for invalid type conversions.
GH3530: Add locale specific tests to check for invalid type conversions.
May 15, 2024
deAtog
force-pushed
the
GH-3530
branch
2 times, most recently
from
May 30, 2024 21:13
2f4730f
to
9e0e6b2
Compare
deAtog
force-pushed
the
GH-3530
branch
12 times, most recently
from
June 10, 2024 18:39
1fef1a9
to
c2035fe
Compare
…he identity column.
deAtog
force-pushed
the
GH-3530
branch
6 times, most recently
from
June 11, 2024 13:17
cc0aff8
to
3d8bc0e
Compare
…ssible and use Convert with the user provided locale if necessary.
…or of the BooleanType.
…behavior of the CharBooleanType.
…d return a DbDataReader.
…values returned from the indexer method.
…to the ReflectionBasedDriver to allow derived classes to access the type information.
…tChar and does not convert strings to datetime values. Add a custom OracleDbDataReader to address these issues.
…from the database to decimal types. Add a MySqlDbDataReader to correct this deficiency.
…onvert dates stores as strings. Address this issue by adding a FirebirdDbDataReader.
…Char method. Add a NoCharDbDataReader to use with these drivers.
…bDataReader.GetChar method, wrap it in a NoCharDbDataReader.
…the DbDataReader.GetChar method, wrap it with the NoCharDbDataReader.
…bDataReader.GetChar method, wrap it in the NoCharDbDataReader.
…taReader.GetChar method, wrap it in the NoCharDbDataReader.
…atch all types of exceptions.
…ile retrieving a value.
…taReader.GetChar and incorrectly uses Convert without specifying an IFormatProvider. Wrap the SAP SqlAnywhere DbDataReader in a SqlAnywhereDbDataReader to correct these issues.
…lement DbDataReader.GetChar and incorrectly uses Convert without specifying an IFormatProvider. Wrap the Sybase SqlAnywhere DotNet4 DbDataReader in a SqlAnywhereDbDataReader to correct these issues.
…bDataReader.GetChar and incorrectly uses Convert without specifying an IFormatProvider. Wrap the Sybase SqlAnywhere DbDataReader in a SqlAnywhereDbDataReader to correct these issues.
…s when calling DbDataReader.GetValues()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a work in progress for adding locale specific tests.