PostgreSQL support for import.py #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhoening
added a commit
that referenced
this pull request
Mar 28, 2013
PostgreSQL support for import.py
|
Thanks. As far as I'm concerned, this looks good (I didn't run it on Postgres myself). We already had a ticket for Postgres support, btw (#37), where I'm not sure all issues have been addressed, so I'll l eave that open for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Your starred/sharing import script produces SQL that's incompatible with PostgreSQL. The main issue is escaping quotes, both double and single, but there are some issues with booleans and dates as well. I've made some small changes to your script that allows it to produce PostgreSQL compatible output while still defaulting to MySQL.
-Tafryn