chore: update graphql dependency and use features #144
Conversation
| @@ -23,7 +23,7 @@ dependencies: | |||
| nhost_graphql_adapter: ^4.0.5 | |||
| dev_dependencies: | |||
| fake_async: ^1.3.1 | |||
| graphql: ^5.1.3 | |||
There was a problem hiding this comment.
please, let's not upgrade to beta versions unless there is a very good reason for it
| @@ -7,7 +7,7 @@ environment: | |||
| sdk: ">=2.18.0 <4.0.0" | |||
|
|
|||
| dependencies: | |||
| graphql: ^5.1.3 | |||
There was a problem hiding this comment.
please, let's not upgrade to beta versions unless there is a very good reason for it
|
Hello, thanks a lot for the PR. Just a bit concerned about the upgrade to a beta package but otherwise this LGTM. |
|
We can leave this PR as draft for now. I'll add a workaround in the issue while waiting for official release. |
|
Sorry, didn't mean to shutdown or delay this PR. If there is a good reason like "there is no further development in the 5.1 branch and this branch is missing much needed features" that might be a good reason to make an exception here. I was mostly trying to understand the rationale behind the use of a beta version so if you could explain a bit the situation that would help moving this PR forward. Thanks again for the work! |
|
@dbarrosop Hello The latest beta release includes the timeouts, defaultPolicies and other configs I'm not familiar of but can be useful for others. It also allows better support for the latest Flutter versions and other dependencies |
|
Based on what you are saying and what I could see online I am leaning towards approving the use of this beta version. Looks like 5.1 is 22 months old which isn't too great. I will ask a colleague to review soon. |
|
Just a quick update, if by the end of Jan there isn't a stable release I think we should move forward with this PR |
|
I just checked and no release yet, I'd suggest updating the dep to v5.2.0-beta.10 and then me can merge. Thanks a lot for the work here. |
|
Okay, will work on the dependency update
…On Fri, 31 Jan 2025 at 7:52 pm, David Barroso ***@***.***> wrote:
I just checked and no release yet, I'd suggest updating the dep to
v5.2.0-beta.10
<https://github.com/zino-hofmann/graphql-flutter/releases/tag/v5.2.0-beta.10>
and then me can merge.
—
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2AUYQXEGBBQMXKMS3KKQL2NNPWHAVCNFSM6AAAAABQ366G4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRXGAZDMMZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| alwaysRebroadcast: alwaysRebroadcast ?? false, | ||
| deepEquals: deepEquals, | ||
| deduplicatePollers: deduplicatePollers ?? false, | ||
| queryRequestTimeout: queryRequestTimeout ?? const Duration(seconds: 5), |
There was a problem hiding this comment.
@dbarrosop would it be much better to increase the request timeout for it let's say 1 or 3 mins to avoid unexpected timeouts when devs updates to the new version?
They might have sudden timeouts when they haven't read the new changes
There was a problem hiding this comment.
note: the 5 seconds was taken from the default value of the dep itself
There was a problem hiding this comment.
another side note: we should probably wait for this PR to be merged then update the gql_websocket_link dep before we update to v5.2.0-beta.10
graphqlversion 5.1.3 is almost 2 years old, since then numerous updates were made up until 5.2.0-beta.9 version which has more features and more control over the packageold:
new:
I created this PR for PGs who want to use the latest version of
graphqlpackage.