Skip to content

Commit

Permalink
[PRMP-1367] changes
Browse files Browse the repository at this point in the history
  • Loading branch information
NogaNHS committed Jan 24, 2025
1 parent bac5894 commit bfa0177
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lambdas/tests/unit/handlers/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def mock_upload_lambda_disabled(mocker):


@pytest.fixture
def mock_upload_lambda_disabled(mocker):
def mock_validation_strict_disabled(mocker):
mock_function = mocker.patch.object(FeatureFlagService, "get_feature_flags_by_flag")
mock_upload_lambda_feature_flag = mock_function.return_value = {
"lloydGeorgeValidationStrictMode": False
Expand Down
8 changes: 4 additions & 4 deletions lambdas/tests/unit/handlers/test_bulk_upload_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def mock_service(mocker):
yield mocker.patch.object(BulkUploadService, "process_message_queue")


def test_can_process_event_with_one_message(mock_service, context, set_env, mock_upload_lambda_disabled):
def test_can_process_event_with_one_message(mock_service, context, set_env, mock_validation_strict_disabled):
expected = ApiGatewayResponse(
200, "Finished processing all 1 messages", "GET"
).create_api_gateway_response()
Expand All @@ -24,7 +24,7 @@ def test_can_process_event_with_one_message(mock_service, context, set_env, mock
assert expected == actual


def test_can_process_event_with_several_messages(mock_service, context, set_env, mock_upload_lambda_disabled):
def test_can_process_event_with_several_messages(mock_service, context, set_env, mock_validation_strict_disabled):
expected = ApiGatewayResponse(
200, "Finished processing all 3 messages", "GET"
).create_api_gateway_response()
Expand All @@ -34,7 +34,7 @@ def test_can_process_event_with_several_messages(mock_service, context, set_env,


def test_receive_correct_response_when_service_returns_error(
mock_service, context, set_env, mock_upload_lambda_disabled
mock_service, context, set_env, mock_validation_strict_disabled
):
expected = ApiGatewayResponse(
500, "Bulk upload failed with error: ", "GET"
Expand All @@ -46,7 +46,7 @@ def test_receive_correct_response_when_service_returns_error(


def test_receive_correct_response_when_no_records_in_event(
mock_service, context, set_env, mock_upload_lambda_disabled
mock_service, context, set_env, mock_validation_strict_disabled
):
expected = ApiGatewayResponse(
400,
Expand Down

0 comments on commit bfa0177

Please sign in to comment.