add propagation check to layer update script

nhsconnect · Jan 23, 2025 · dcf923e · dcf923e
1 parent 6099661
commit dcf923e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/.github/workflows/base-lambdas-reusable-deploy.yml b/.github/workflows/base-lambdas-reusable-deploy.yml
@@ -87,9 +87,6 @@ jobs:
 
       - name: Upload Lambda Function zip to ${{ inputs.lambda_aws_name }}
         run: |
-          sleep 3
-          export AWS_RETRY_MODE=standard
-          export AWS_MAX_ATTEMPTS=5
           aws lambda update-function-code \
           --function-name ${{ inputs.sandbox }}_${{ inputs.lambda_aws_name }} \
           --zip-file fileb://build/lambdas/${{ inputs.lambda_handler_name }}/${{ inputs.lambda_handler_name }}.zip
diff --git a/lambdas/scripts/lambda_layer_update.py b/lambdas/scripts/lambda_layer_update.py
@@ -1,5 +1,6 @@
 import re
 import sys
+import time
 
 import boto3
 
@@ -27,6 +28,7 @@ def start(self):
         self.extract_default_layer_arns()
         self.extract_updated_layer_arns()
         self.update_lambda()
+        self.propagate_lambda_update()
 
     def extract_default_layer_arns(self):
         response = self.client.get_function(FunctionName=self.function_name_aws)
@@ -63,6 +65,22 @@ def update_lambda(self):
             Layers=list(self.updated_lambda_arns.values()),
         )
 
+    def propagate_lambda_update(self):
+        retry_count = 3
+        for i in range(retry_count):
+            time.sleep(3)
+            print(f"Propagating lambda layer update attempt {i}...")
+            response = self.client.client.get_function_configuration(
+                FunctionName=self.function_name_aws
+            )
+            if (
+                response["State"] == "Active"
+                and response["LastUpdateStatus "] == "Successful"
+            ):
+                break
+
+            print("Lambda state is not ready, retrying...")
+
 
 if __name__ == "__main__":
     layer_update = LambdaLayerUpdate()