Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRMP-1355] Updated workflows to use newest available dependencies #503

Closed
wants to merge 6 commits into from
Closed

[PRMP-1355] Updated workflows to use newest available dependencies #503

wants to merge 6 commits into from

Conversation

oliverbeumkes-nhs
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2025
View reviewed changes
.github/workflows/base-cypress-build.yml Dismissed Show dismissed Hide dismissed
.github/workflows/base-cypress-smoketest.yml Dismissed
with:
repository: 'nhsconnect/national-document-repository'
ref: ${{ inputs.build_branch}}

- name: AWS Role
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Z-BASE Cypress Smoketest: Smoketest shared actions for running' step
Uses Step
Loading
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs mask-aws-account-id?

.github/workflows/base-cypress-smoketest.yml Dismissed
with:
repository: 'nhsconnect/national-document-repository'
ref: ${{ inputs.build_branch}}

- name: AWS Role
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Z-BASE Cypress Smoketest: Smoketest shared actions for running' step
Uses Step
Loading
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs mask-aws-account-id?

.github/workflows/base-cypress-smoketest.yml Dismissed
with:
repository: 'nhsconnect/national-document-repository'
ref: ${{ inputs.build_branch}}

- name: AWS Role
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Z-BASE Cypress Smoketest: Smoketest shared actions for running' step
Uses Step
Loading
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs mask-aws-account-id?

.github/workflows/base-deploy-ui.yml Fixed Show fixed Hide fixed
.github/workflows/dispatch-full-lambdas-dispatch-deploy.yml Fixed Show resolved Hide resolved
.github/workflows/dispatch-full-lambdas-dispatch-deploy.yml Fixed Show resolved Hide resolved
.github/workflows/dispatch-full-lambdas-dispatch-deploy.yml Fixed Show resolved Hide resolved
.github/workflows/full-ui-dispatch-deploy.yml

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'FULL UI - Dispatch Deploy' step
Uses Step
Loading
uses 'aws-actions/configure-aws-credentials' with ref 'v4', not a pinned commit hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs mask-aws-account-id?

.github/workflows/full-ui-dispatch-deploy.yml Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbloe-nhse chrisbloe-nhse chrisbloe-nhse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverbeumkes-nhs @chrisbloe-nhse @abbas-khan10