GitHub workflows: Test with Python 3.13 and use Python 3.11.9 by default #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
commented
Jan 28, 2025
| @@ -62,14 +62,15 @@ ni-python-styleguide = ">=0.4.1" | |||
| # and regenerate gRPC stubs. | |||
| grpcio-tools = [ | |||
| {version = "1.49.1", python = ">=3.8,<3.12"}, | |||
| {version = "1.59.0", python = "^3.12"}, | |||
| {version = "1.59.0", python = ">=3.12,<3.13"}, | |||
| {version = "1.67.0", python = "^3.13"}, | |||
There was a problem hiding this comment.
This is incompatible with nimi-python's protobuf version constraint: ni/nimi-python#2075
bkeryan
commented
Jan 28, 2025
There was a problem hiding this comment.
This poetry.lock is out of date due to the nimi-python <-> grpcio-tools <-> protobuf version conflict.
Run poetry check --lock
poetry check --lock
shell: /usr/bin/bash -e {0}
env:
POETRY_VERSION: 1.8.[2](https://github.com/ni/measurement-plugin-python/actions/runs/13020781477/job/36320812060#step:5:2)
PYTHON_VERSION: [3](https://github.com/ni/measurement-plugin-python/actions/runs/13020781477/job/36320812060#step:5:3).11.9
pythonLocation: /opt/hostedtoolcache/Python/3.11.9/x6[4](https://github.com/ni/measurement-plugin-python/actions/runs/13020781477/job/36320812060#step:5:4)
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.9/x[6](https://github.com/ni/measurement-plugin-python/actions/runs/13020781477/job/36320812060#step:5:6)4/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.[9](https://github.com/ni/measurement-plugin-python/actions/runs/13020781477/job/36320812060#step:5:9)/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib
Error: pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.
Error: Process completed with exit code 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update GitHub workflows to run tests with Python 3.13 and to use Python 3.11.9 by default for non-versioned scripts/testing.
Why should this Pull Request be merged?
Follow NI Python versioning policy.
Removing Python 3.8 will be in a separate PR.
What testing has been done?
PR build.