Update Measurement Plug-In Generated Client to Resolve with the Corresponding Measurement Service Version

[Jotheeswaran-Nandagopal]

• This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

• Add version as a parameter in the resolve_service API of the discovery client with respect to the latest change in ni-apis.
• Update the unit tests for the resolve_service API with version parameter.
• Update the Mako template of Measurement Plug-In Client generator to resolve the service with the version of the measurement.

Why should this Pull Request be merged?

• The ResolveServiceRequest has been updated in the ni-apis, with version.

• As, multiple versions of same measurement can be registered simultaneously, the resolve service will fetch the service with latest version, if the version is not specified while resolving. So, when a user creates a client with version 1.0.0.0 and later, run the measure() API in client with higher version 2.0.0.0 of registered measurement, the service location will be resolved without any error, as the version is not checked. With this, if the configurations are updated in new version of measurement, this will result in error during measure call.

• With the implementation in this Pull Request (adding version), client will be generated for the latest version (as multiple versions are not supported at present). During the measurement process in the generated client, measurement service will be resolved with the version of the generated client. If the version mismatch is captured, throw error appropriately.

What testing has been done?

• Done manual testing
• Automated test cases passed

[github-actions]

Test Results

    40 files  ± 0      40 suites  ±0   53m 51s ⏱️ + 1m 13s
   695 tests + 1     695 ✅ + 1      0 💤 ±0  0 ❌ ±0 
16 890 runs  +30  15 820 ✅ +30  1 070 💤 ±0  0 ❌ ±0 

Results for commit 1386842. ± Comparison against base commit 113b166.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.

tests.unit.test_discovery_client ‑ test___service_registered___resolve_service___sends_request

tests.unit.test_discovery_client ‑ test___service_registered___resolve_service_with_version___sends_request
tests.unit.test_discovery_client ‑ test___service_registered___resolve_service_without_version___sends_request

♻️ This comment has been updated with latest results.

[jayaseelan-james]

Following #907, in a separate PR please consider moving the version of the test measurements from __init__.py to its corresponding .serviceconfig.

[bkeryan]

@Jotheeswaran-Nandagopal @Avinash2Suresh I think part of what's going on with the build failures is that our virtualenv caching uses the poetry.lock as a key, and this doesn't change when you modify files in ../../packages/service.

https://github.com/ni/measurement-plugin-python/blob/main/.github/workflows/run_system_tests.yml

[jayaseelan-james]

If you're updating the version of the service pkg, then please update the version of the generator and SDK packages as well.

[Jotheeswaran-Nandagopal]

As per the updates in #911, I have moved the version from the constructor to .serviceconfig file, as the pipelines are failing due to the requirement to include the version in the generated client.

[Jotheeswaran-Nandagopal]

@Jotheeswaran-Nandagopal @Avinash2Suresh I think part of what's going on with the build failures is that our virtualenv caching uses the poetry.lock as a key, and this doesn't change when you modify files in ../../packages/service.

https://github.com/ni/measurement-plugin-python/blob/main/.github/workflows/run_system_tests.yml

@bkeryan I have updated the package versions as service package is updated, in order to resolve the pipeline failure caused by our virtualenv caching.

[bkeryan]

@Jotheeswaran-Nandagopal @Avinash2Suresh I think part of what's going on with the build failures is that our virtualenv caching uses the poetry.lock as a key, and this doesn't change when you modify files in ../../packages/service.
https://github.com/ni/measurement-plugin-python/blob/main/.github/workflows/run_system_tests.yml

@bkeryan I have updated the package versions as service package is updated, in order to resolve the pipeline failure caused by our virtualenv caching.

#941